NPC Saber Colors Malfunctional

[OOM-10]

Hello! I've run into an issue where NPCs are not using the saber colors defined in the .npc files. Instead, it seems that the game is using whatever colors are defined within the .sab files. If I remove "saberColor" from the .sab files, the sabers simply default to red. The NPC saber colors were previously working with a slightly customized build of OpenJK, so it appears to be an issue with JA++.

For reference, I compiled JA++ myself with the source code available here. I made a few minor modifications to increase limits such as the amount of player models that can be displayed in the menus, the amount of saber hilts that can be loaded in, etc.

[redsaurus]

NPC sabercolours aren't networked by default, so never get sent over to the client. This was changed in the OpenJK game/cgame (though not in a very nice way), but probably not in JA++.

You might be able to cherry-pick the relevant commits from OpenJK (or just copy over the changes):

first one: https://github.com/JACoders/OpenJK/commit/ae83820c42a83cb8d10603d86b477300aae4c4c8 

second one (fixes first): https://github.com/JACoders/OpenJK/commit/d3bfe2880605683f4c65abf79181a0362d5379f6

[OOM-10]

Thanks a lot! Works like a charm. I had no idea that was a new feature added in OpenJK since I've rarely played with the original executables.

[Raz0r]

Thanks for the report, added to JA++ as of commit 23ea718